Changelog #13
Closed
Changelog #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I included the changes from #12 since that was easier, and this is bound to conflict with that otherwise. The changelog would be made "prettier", and I still need to figure out wrapping, but that's mostly going to be either in the HTML or maybe (unlikely) HTMLViewer. |
* Changelog is HTML, shown via HTMLViewer, which is also used by Settings -> About -> Legal * Changelog file: <device>-<channel>-changelog.html * Show changelog if it exists upon tapping the notification, or the settings entry. Potential TODOs: * The view can be zoomed in and out (which may be useful), and also scrolled around easily (not so useful).
chirayudesai
force-pushed
the
changelog
branch
from
dd507c7 to
a2904d7
Compare
chirayudesai
commented
Aug 26, 2019
| } | ||
|
|
||
| static Intent getChangelogIntent(Context context, String filename) { | ||
| // From com.android.settings.SettingsLicenseActivity.showHtmlFromUri() |
There was a problem hiding this comment.
This code is Apache2
|
By the way this got closed from removing the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes the changes from #12 to make things easier.
Changelog is HTML, example can be seen at #9 (comment)
It's not exactly the best system, and the changelog downlaod only happens alongwith update download, but I feel that this is sufficiently usable.
Closes #9